feat(useDraggable): support customizing trigger element
#2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Aug 29, 2022
packages/core/useDraggable/demo.vue
Outdated
| class="fixed bg-$vp-c-bg select-none z-10" | ||
| :initial-value="{ x: innerWidth / 3.9, y: 240 }" | ||
| :prevent-default="true" | ||
| handle=".handle" |
There was a problem hiding this comment.
I am not so sure about using a selector string here. I would prefer always to accept element instances using template ref.
There was a problem hiding this comment.
I have no opinion. I will romove it, please check the changes.
imguolao
force-pushed
the
feat/use-draggable/trigger-handle
branch
from
c0394bb
to
357c7ee
Compare
antfu
changed the title
trigger element
antfu
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Click the handle to drag instead of clicking the entire target to drag.
fixed #1910
Additional context
Whether the trigger handle must be included in the target?
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).