Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useAxios): support RequestConfig for execute #2152

Merged
merged 2 commits into from Sep 2, 2022
Merged

feat(useAxios): support RequestConfig for execute #2152

merged 2 commits into from Sep 2, 2022

Conversation

azaleta
Copy link
Contributor

@azaleta azaleta commented Sep 1, 2022

Description

related issue: #2149

https://github.com/vueuse/vueuse/blob/main/packages/integrations/useAxios/index.test.ts#L109
This is a little bit strange.

Make some type improve for using execute smoothly.(keep url as same and change request param etc.)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

songjianet
songjianet approved these changes Sep 2, 2022
View reviewed changes
Copy link

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antfu antfu changed the title feature(useAxios): improve type feat(useAxios): support RequestConfig for execute Sep 2, 2022
@antfu antfu enabled auto-merge (squash) September 2, 2022 04:38
@antfu antfu merged commit 92630dd into vueuse:main Sep 2, 2022
@renovate renovate bot mentioned this pull request Sep 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@songjianet songjianet songjianet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azaleta @antfu @songjianet