Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useWindowSize): support includeScrollbar #2161

Merged
merged 2 commits into from Sep 4, 2022

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Sep 3, 2022

scrollbar size is included in window.innerWidth / window.innerHeight, we don't want it in some cases.
For example, to calculate the top/left/right/bottom offset for a position: fixed element.

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vaakian vaakian mentioned this pull request Sep 3, 2022
9 tasks
Copy link

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxzz sxzz merged commit d278f0b into vueuse:main Sep 4, 2022
@vaakian vaakian deleted the useWindowSize branch September 5, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants