Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useUrlSearchParams): add write option #2165

Merged
merged 5 commits into from Sep 4, 2022
Merged

feat(useUrlSearchParams): add write option #2165

merged 5 commits into from Sep 4, 2022

Conversation

waldonUB
Copy link
Contributor

@waldonUB waldonUB commented Sep 3, 2022

Description

Additional context

fix #2164

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

zyyv
zyyv suggested changes Sep 4, 2022
View reviewed changes
packages/core/useUrlSearchParams/index.ts Outdated Show resolved Hide resolved
@waldonUB @zyyv
Update packages/core/useUrlSearchParams/index.ts
c894693 
Co-authored-by: Chris <1633711653@qq.com>
sxzz
sxzz previously approved these changes Sep 4, 2022
View reviewed changes
@sxzz
Copy link
Member

sxzz commented Sep 4, 2022

Please fix lint.

@antfu antfu changed the title fix: add option in useUrlSearchParams fix(useUrlSearchParams): add write option Sep 4, 2022
@antfu antfu changed the title fix(useUrlSearchParams): add write option feat(useUrlSearchParams): add write option Sep 4, 2022
@waldonUB waldonUB requested a review from sxzz September 4, 2022 10:14
@sxzz sxzz merged commit 7b2887e into vueuse:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyyv zyyv zyyv requested changes

@antfu antfu antfu approved these changes

@sxzz sxzz Awaiting requested review from sxzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is a problem in Promise when I using useUrlSearchParams
4 participants
@waldonUB @sxzz @antfu @zyyv