Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useEventListener): accept multiple events or listeners #2180

Merged
merged 7 commits into from Nov 9, 2022

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Sep 8, 2022

Description

Allow useEventListener to accept array of events or listeners so that we could:

  • add multiple listeners to a single event
  • add a single listener to multiple events

It looks like:

// multi event
useEventListener(
  ['scroll', 'click', 'resize', 'blur'],
  handler,
)

// multi handler
useEventListener(
  'scroll' ,
  [handler1, handler2, handler3],
)

// multi event & multi handler
useEventListener(
  ['scroll', 'click', 'resize', 'blur'], 
  [handler1, handler2, handler3],
)

Additional context

This change is incremental, fully compatible with previous usage.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vaakian vaakian changed the title feat(useEventListener): accept array of events or listeners feat(useEventListener): accept multiple events or listeners Sep 8, 2022
@vaakian
Copy link
Contributor Author

vaakian commented Sep 8, 2022

@stale
Copy link

stale bot commented Nov 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 7, 2022
@sxzz
Copy link
Member

sxzz commented Nov 7, 2022

I don't think this feature is essential.

@stale stale bot removed the stale label Nov 7, 2022
antfu
antfu previously approved these changes Nov 8, 2022
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r

@antfu antfu merged commit ab0eea2 into vueuse:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants