Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useStorage): fixed data desynchronization in case of clearing storage #2221

Merged
merged 5 commits into from Oct 16, 2022

Conversation

yuryrudey
Copy link
Contributor

Description

Fixes data desynchronization in case of clearing storage(using storage.clear() or manually)
Condition to detect storage clearing is taken from documentation(pay attention to description of key property)

Additional context

Using useStorage I noticed that after clearing storage in Chrome DevTools, my computed property wasn't recomputed. The cause was condition in the storage event handler that ignored this case


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@yuryrudey yuryrudey changed the title fix(useStorage): added reset after calling storage.clear() method fix(useStorage): fixed data desynchronization in case of clearing storage Sep 18, 2022
@antfu antfu merged commit a06b7bd into vueuse:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants