Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useFirestore): auto dispose documents #2318

Merged
merged 1 commit into from Oct 16, 2022
Merged

fix(useFirestore): auto dispose documents #2318

merged 1 commit into from Oct 16, 2022

Conversation

Zehir
Copy link
Contributor

@Zehir Zehir commented Oct 12, 2022

Description

As we say in #2276, until we figure out how we will make the new autodispose option it's need to at least enable back the auto dispose of documents.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [] Ideally, include relevant tests that fail without this PR but pass with it.

@Zehir
Copy link
Contributor Author

Zehir commented Oct 12, 2022

@kiyopikko the PR you asked for ;)

@Zehir
Copy link
Contributor Author

Zehir commented Oct 12, 2022

Original message about this issue: #2252 (comment)

kiyopikko
kiyopikko approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@kiyopikko kiyopikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@antfu antfu changed the title feat(useFirestore): auto dispose documents fix(useFirestore): auto dispose documents Oct 16, 2022
@antfu antfu enabled auto-merge (squash) October 16, 2022 22:39
@antfu antfu merged commit 66f56d2 into vueuse:main Oct 16, 2022
@Zehir Zehir deleted the fix-autodispose branch October 16, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiyopikko kiyopikko kiyopikko approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zehir @kiyopikko @antfu