fix(useDevicePixelRatio): remove unnecessary cleanup #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Oct 16, 2022
| const observe = () => { | ||
| pixelRatio.value = window.devicePixelRatio | ||
| cleanup() | ||
| const media = window.matchMedia(`(resolution: ${pixelRatio.value}dppx)`) | ||
| media = window.matchMedia(`(resolution: ${pixelRatio.value}dppx)`) |
There was a problem hiding this comment.
Maybe we could do a clean up for the previous event then?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
useDevicePixelRatiofunction, we don't have to remove the listener with every invoke, because we already setonce: true, we only need to remove the last listener observed on disposeAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).