Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): wrap ssr plugin in defineNuxtPlugin #2326

Merged
merged 2 commits into from Oct 16, 2022
Merged

fix(nuxt): wrap ssr plugin in defineNuxtPlugin #2326

merged 2 commits into from Oct 16, 2022

Conversation

dan-online
Copy link
Contributor

Description

When using the nuxt package, the console outputs the warning:

[warn] [nuxt] You are using a plugin that has not been wrapped in `defineNuxtPlugin`. It is advised to wrap your plugins as in the future this may enable enhancements: () => { }

This pull request simply wraps the ssr-plugin file export with defineNuxtPlugin

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dan-online dan-online changed the title fix: wrap ssr plugin in defineNuxtPlugin fix(nuxt): wrap ssr plugin in defineNuxtPlugin Oct 15, 2022
@antfu antfu enabled auto-merge (squash) October 16, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants