Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extendRef() with Vue 2.7 #2340

Closed
4 tasks done
posva opened this issue Oct 20, 2022 · 3 comments
Closed
4 tasks done

Support extendRef() with Vue 2.7 #2340

posva opened this issue Oct 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@posva
Copy link
Contributor

posva commented Oct 20, 2022

Clear and concise description of the problem

@vue/composition-api has a limitation that prevents extendRef() to be used but this is not the case for Vue 2.7

Suggested solution

I think vue-demi could expose a variable isNativeCompositionAPI or similar.

Even without that, using import { version } from 'vue' should work in most cases to check if it's vue >= 2.7 and allow using extendRef().

Alternative

No response

Additional context

Validations

@posva posva added the enhancement New feature or request label Oct 20, 2022
@stale
Copy link

stale bot commented Dec 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 19, 2022
@posva
Copy link
Contributor Author

posva commented Dec 19, 2022

up

@stale stale bot removed the stale label Dec 19, 2022
@antfu antfu closed this as completed in 8c82e5e Dec 19, 2022
@antfu
Copy link
Member

antfu commented Dec 19, 2022

Making sense, implemented. isNativeCompositionAPI might be a good idea, but I feel vue-demi is already a bit overwhelming. Since we can have the info via version, let's use it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants