Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usePointerSwipe): handle secondary clicks properly #2379

Merged
merged 1 commit into from Nov 9, 2022
Merged

fix(usePointerSwipe): handle secondary clicks properly #2379

merged 1 commit into from Nov 9, 2022

Conversation

curtgrimes
Copy link
Contributor

@curtgrimes curtgrimes commented Oct 29, 2022

Description

Fix issue where a secondary click (the right button on a right-handed mouse) on an element using usePointerSwipe() is treated as if the primary button (left click on a right-handed mouse) has started a drag.

  • Rename filterEvent() to eventIsAllowed() for better clarity
  • Fix typo in docs and make punctuation consistent

Fixes #2338

Before

  1. Right click on the button
  2. Hit the Escape key to dismiss the context menu
  3. Without clicking, move the mouse around over the button. The button behaves as if it is being dragged.

CleanShot 2022-10-29 at 12 06 01

After

A right click does nothing other than open the context menu as usual.

CleanShot 2022-10-29 at 12 08 22

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

…perly

Fix issue where a secondary click (the right button on a right-handed
mouse) on an element using usePointerSwipe() is treated as if the
primary button (left click on a right-handed mouse) has started a drag.

- Rename filterEvent() to eventIsAllowed() for better clarity
- Fix typo in docs and make punctuation consistent

Fixes #2338
@antfu antfu changed the title Fix issue where usePointerSwipe() doesn't handle secondary clicks properly fix(usePointerSwipe): handle secondary clicks properly Nov 9, 2022
@antfu antfu merged commit 862d127 into vueuse:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usePointerSwipe right mouse click response problem
2 participants