Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useScroll): the expected result cannot be returned after setting the throttle parameter #2390

Merged
merged 1 commit into from Nov 8, 2022

Conversation

LittleSound
Copy link
Contributor

@LittleSound LittleSound commented Nov 1, 2022

Fixes #2389

Description

I first ran into this problem when using the useInfiniteScroll function, which caused the list to not load more contents once it was scrolled to the bottom.
The reason for this bug is that the useThrottleFn used in useScroll is not configured properly with: [trailing=true] and [leading=false],where it ensures that the function must be executed once after the scrolling ends.

The way the bug is reproduced:

2022-11-01.23.06.36.mov

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants