Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onClickOutside): support options in component #2391

Merged
merged 2 commits into from Nov 4, 2022
Merged

Conversation

fiadone
Copy link
Contributor

@fiadone fiadone commented Nov 1, 2022

Description

It adds support for the options property when using onClickOutside via component.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

It adds support for the options property when using onClickOutside via component
sxzz
sxzz previously approved these changes Nov 1, 2022
@sibbng sibbng changed the title fix(onClickOutside): missing options for component feat(onClickOutside): support options in component Nov 4, 2022
@sibbng sibbng enabled auto-merge (squash) November 4, 2022 11:08
@sibbng sibbng merged commit c913b8f into vueuse:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants