fix(useFirestore): fix falsy type error #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiyopikko
commented
Nov 11, 2022
| @@ -33,25 +33,27 @@ function isDocumentReference<T>(docRef: any): docRef is DocumentReference<T> { | |||
| return (docRef.path?.match(/\//g) || []).length % 2 !== 0 | |||
| } | |||
|
|
|||
| type Falsy = false | 0 | '' | null | undefined | |||
There was a problem hiding this comment.
Adding Falsy fixed these errors
| maybeDocRef: MaybeRef<DocumentReference<T> | false>, | ||
| initialValue?: T | undefined, | ||
| maybeDocRef: MaybeRef<DocumentReference<T> | Falsy>, | ||
| initialValue?: T | undefined | null, |
There was a problem hiding this comment.
this line fixed the error below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now you can use only
falsevalue for dependent query, so I addedFalsytype.Additional context
Also fixed to use
nullvalue to initial value.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).