fix(useStyleTag): allow use of existing node #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibbng
approved these changes
Nov 14, 2022
sibbng
requested changes
Nov 14, 2022
packages/core/useStyleTag/index.ts
Outdated
| @@ -76,7 +76,9 @@ export function useStyleTag( | |||
| el.id = id | |||
| if (options.media) | |||
| el.media = options.media | |||
There was a problem hiding this comment.
Could you fix lint errors and move the lines 75-78 inside the if (!el.isConnected)?
fix(useStyleTag): wrap all DOM updates in condition
sibbng
approved these changes
Nov 17, 2022
|
wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using useStyleTag with an ID this PR ensures that if the target ID already exists, don't re-append the node to the document
<head>causing the node to move in the DOM.This allows an empty style node to be placed in the page template & useStyleTag will use/update that - in-place, e.g.
Additional context
When style elements move in the DOM it can cause unintended side-effects in terms of CSS specificity.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).