Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr-plugin): use useHead instead of useMeta #2449

Merged
merged 1 commit into from Nov 16, 2022

Conversation

daniil4udo
Copy link
Contributor

@daniil4udo daniil4udo commented Nov 16, 2022

Description

There is no useMeta

Additional context

Breaks Nuxt3 RC.14


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@harlan-zw
Copy link
Contributor

lgtm, I can't approve though

@antfu antfu changed the title fix: use useHead instead of useMeta fix(ssr-plugin): use useHead instead of useMeta Nov 16, 2022
@antfu antfu merged commit 01c2820 into vueuse:main Nov 16, 2022
@daniil4udo daniil4udo deleted the fix/deprecate-useMeta branch November 16, 2022 14:14
@Developer27149
Copy link

@antfu Hello,When is the next release? 🚀

@shtse8
Copy link

shtse8 commented Nov 18, 2022

I am still waiting for this fix to upgrade my nuxt version to 3.0 stable.

@pichean
Copy link

pichean commented Nov 18, 2022

I think code is fixed but npm package is not yet published the latest version.

@yeonjulee1005
Copy link

in my case, my pacakge manager 'yarn' but, there is same phenomenon.

@ErriourMe
Copy link

We are waiting new version of module 🙂


in my case, my pacakge manager 'yarn' but, there is same phenomenon.

It doesnt matter. You still use mostly npm packages from npmjs.com in Yarn or pnpm.

@mklueh
Copy link

mklueh commented Nov 20, 2022

There was no release triggered yet, only the PR merge: https://github.com/vueuse/vueuse/actions/workflows/publish.yml

@shtse8
Copy link

shtse8 commented Nov 20, 2022

This fix should be released asap as it breaks stable nuxt 3.

@webfansplz
Copy link
Member

/cc @antfu

@jamieowen
Copy link

jamieowen commented Nov 21, 2022

Same issue :)

Also, any official instructions on how to upgrade to Nuxt 3 Stable?

Running npx nuxi upgrade only upgrades to rc14.

Cheers!

@virakkhun
Copy link

I've solved this issue by modified vueuse option in nuxt.config.ts as following.

currently on: "nuxt": "^3.0.0" and "@vueuse/nuxt": "^9.5.0"

export default defineNuxtConfig({
  vueuse: {
     ssrHandlers: false
  }
})

@shtse8
Copy link

shtse8 commented Nov 22, 2022

I've solved this issue by modified vueuse option in nuxt.config.ts as following.

currently on: "nuxt": "^3.0.0" and "@vueuse/nuxt": "^9.5.0"

export default defineNuxtConfig({
  vueuse: {
     ssrHandlers: false
  }
})

Yes, this is the temporary solution to disable ssrHandlers to make it works. But the theme mode will not work if the SSRHandlers is disabled.

@ErriourMe
Copy link

ErriourMe commented Nov 22, 2022

9.6.0 with fix was released 🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet