Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMouseInElement): check if mouse out of window #2458

Merged
merged 2 commits into from Jan 29, 2023

Conversation

chaii3
Copy link
Contributor

@chaii3 chaii3 commented Nov 20, 2022

fixes #2454

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Contributor

@yysuen yysuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the import statement prefers not to include index in path. 👇

https://github.com/vueuse/vueuse/blob/main/packages/core/useMouseInElement/index.ts#L3

What about considering to modify the import path?

- import { useEventListener } from '../useEventListener/index'
+ import { useEventListener } from '../useEventListener'

@stale
Copy link

stale bot commented Jan 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2023
@wheatjs wheatjs removed the stale label Jan 25, 2023
@antfu antfu merged commit 54f4e72 into vueuse:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useMouseInElement still thinks mouse is within element when leaving the browser window
4 participants