Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useAxios): assign AxiosError to error.value when no url provided (close #2478) #2484

Merged
merged 3 commits into from Jan 9, 2023

Conversation

yysuen
Copy link
Contributor

@yysuen yysuen commented Nov 29, 2022

Description

Fixes #2478 .

Test case missing url for useAxios expects error.value to be defined when url is missing. However, currently it is undefined.

I assigned an AxioxError to error.value when url is missing at calling useAxios.

const execute: OverallUseAxiosReturn<T, R, D>['execute'] = (executeUrl: string | AxiosRequestConfig<D> | undefined = url, config: AxiosRequestConfig<D> = {}) => {
    error.value = undefined
-    const _url = typeof executeUrl === 'string'
+    let _url = typeof executeUrl === 'string'
      ? executeUrl
-      : url ?? ''
+      : url ?? config.url

+    if (_url === undefined) {
+     error.value = new AxiosError(AxiosError.ERR_INVALID_URL)
+      _url = ''
+   }

    loading(true)
    instance(_url, { ...defaultConfig, ...typeof executeUrl === 'object' ? executeUrl : config, cancelToken: cancelToken.token })
      .then((r: any) => {
        response.value = r
        data.value = r.data
      })
      .catch((e: any) => {
        error.value = e
      })
      .finally(() => loading(false))
    return { then }
  }

Test case missing url is now passing with this PR.

Additional context

Null.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@wheatjs wheatjs merged commit 1e27060 into vueuse:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[useAxios] Test case missing url doesn't pass.
2 participants