Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useDraggable): write to useStorage #2575

Merged
merged 1 commit into from Jan 4, 2023
Merged

Conversation

akifo
Copy link
Contributor

@akifo akifo commented Dec 24, 2022

Description

Fixed a bug that "UseDraggable component" does not write to storage even if storage-key and storage-type are passed.

Additional context

before
In the video example, the position has reverted to (860, 199) after the page change.

before video
CleanShot.2022-12-25.at.00.48.51.mp4

after
The position is persistent even after page change.

after video
CleanShot.2022-12-25.at.00.53.17.mp4

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@wheatjs wheatjs merged commit e39c2a7 into vueuse:main Jan 4, 2023
@akifo akifo deleted the fix/useDraggable branch January 6, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants