feat(useArrayUnique): add a custom function to deduplicate #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
antfu
reviewed
Feb 18, 2023
| @@ -33,6 +33,24 @@ const list = reactive([1, 2, 2, 3]) | |||
| const result = useArrayUnique(list) | |||
| // result.value: [1, 2, 3] | |||
|
|
|||
| result.value.push(1) | |||
| result.push(1) | |||
There was a problem hiding this comment.
What's the reason of this change?
There was a problem hiding this comment.
Sorry here should be list.push I have modified it in the latest commit
| * @returns {Array} A computed ref that returns a unique array of items. | ||
| */ | ||
| export function useArrayUnique<T>( | ||
| list: MaybeComputedRef<MaybeComputedRef<T>[]>): ComputedRef<T[]> { | ||
| return computed<T[]>(() => [...new Set<T>(resolveUnref(list).map(element => resolveUnref(element)))]) | ||
| list: MaybeComputedRef<MaybeComputedRef<T>[]>, fn?: (a: T, b: T, array: T[]) => boolean): ComputedRef<T[]> { |
There was a problem hiding this comment.
Suggested change
| list: MaybeComputedRef<MaybeComputedRef<T>[]>, fn?: (a: T, b: T, array: T[]) => boolean): ComputedRef<T[]> { | |
| list: MaybeComputedRef<MaybeComputedRef<T>[]>, compareFn?: (a: T, b: T, array: T[]) => boolean): ComputedRef<T[]> { |
There was a problem hiding this comment.
Thank you, I have renamed to compareFn.
antfu
added
the
direction: approved
antfu
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
thanks @bpolaszek for the #2610 contribution!
I think it seems more appropriate to use a custom function here
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).