Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(usePrecision): fix return type #2676

Merged
merged 1 commit into from Jan 25, 2023
Merged

fix(usePrecision): fix return type #2676

merged 1 commit into from Jan 25, 2023

Conversation

clemdee
Copy link
Contributor

@clemdee clemdee commented Jan 25, 2023

Description

Return type of usePrecision was ComputedRef<number | string> instead of ComputedRef<number>, which was causing typing annoyance.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit e331b25 into vueuse:main Jan 25, 2023
@clemdee clemdee deleted the fix/usePrecision branch January 26, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clemdee @antfu