Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useClamp): composable computed usage improvements #2696

Merged
merged 4 commits into from Feb 18, 2023

Conversation

clemdee
Copy link
Contributor

@clemdee clemdee commented Jan 29, 2023

Description

This PR aims to improve computed usage of the useClamp composable:

  • feat: make composable accept a function as value parameter
  • fix: when passing a computed value, the composable was throwing as "Write operation failed: computed value is readonly" warning, because it was trying to set the value of its internal ref, which was a computed ref in that case
  • docs: took the opportunity to add an example about the computed usage of useClamp in the doc

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu enabled auto-merge (squash) February 18, 2023 09:48
@antfu antfu merged commit 08a07c5 into vueuse:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants