Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useArrayIncludes): new function #2708

Merged
merged 12 commits into from Mar 4, 2023
Merged

feat(useArrayIncludes): new function #2708

merged 12 commits into from Mar 4, 2023

Conversation

Alfred-Skyblue
Copy link
Member

Description

This hook is used to determine whether the array contains an element

Additional context

useArrayIncludes

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@antfu antfu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #2710, I think a compareFn would make it more flexiable

@antfu antfu added the direction: approved The direction of feature/change is approved by the team. May require some small changes. label Feb 18, 2023
@antfu antfu added this to the 10.0 milestone Mar 4, 2023
@antfu antfu merged commit 4d6bc00 into vueuse:main Mar 4, 2023
@Alfred-Skyblue Alfred-Skyblue deleted the feat-useArrayIncludes branch March 6, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
direction: approved The direction of feature/change is approved by the team. May require some small changes.
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alfred-Skyblue @antfu