Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useArrayDifference): new function #2710

Merged
merged 5 commits into from Mar 4, 2023
Merged

feat(useArrayDifference): new function #2710

merged 5 commits into from Mar 4, 2023

Conversation

Alfred-Skyblue
Copy link
Member

Description

Reactive get array difference of two array

Additional context

useArrayDifference


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to have this function. But using fn with includes might not be flexible enough, especially working with nested objects.

I would advice using compareFn with filter/find to do it.

@antfu antfu added the direction: approved The direction of feature/change is approved by the team. May require some small changes. label Feb 18, 2023
@antfu antfu added this to the 10.0 milestone Mar 4, 2023
@antfu antfu merged commit a2a338d into vueuse:main Mar 4, 2023
@Alfred-Skyblue Alfred-Skyblue deleted the feat-useArrayDifference branch March 6, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
direction: approved The direction of feature/change is approved by the team. May require some small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants