New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useDraggable): support capture
option
#2725
Merged
antfu
merged 7 commits into
vueuse:main
from
faga295:feat/usedraggable_support_useCapture
Apr 13, 2023
Merged
feat(useDraggable): support capture
option
#2725
antfu
merged 7 commits into
vueuse:main
from
faga295:feat/usedraggable_support_useCapture
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaakian
suggested changes
Feb 3, 2023
antfu
reviewed
Feb 18, 2023
antfu
requested changes
Feb 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor using 103d6c0
Thanks
Has refactored, please review again |
antfu
changed the title
Feat/usedraggable support use capture
feat(useDraggable): support Apr 13, 2023
capture
option
antfu
approved these changes
Apr 13, 2023
I would recommend adding this code in case someone decides to call 'open' twice, once with 'capture' and once without it: if (hasOwn(_options, 'capture'))
input.capture = _options.capture!
else
input.removeAttribute('capture') |
This was referenced Nov 13, 2023
This was referenced Dec 3, 2023
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #2724
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).