Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useElementHover): introduce delay hooks #2741

Merged
merged 4 commits into from Feb 18, 2023
Merged

feat(useElementHover): introduce delay hooks #2741

merged 4 commits into from Feb 18, 2023

Conversation

LockingReal
Copy link
Contributor

Description

Give useElementHover hook delay properties,I have done the test myself ~ @Alfred-Skyblue

Additional context

What is the purpose of this pull request?

  • [X ] Bug fix
  • [√ ] New Feature
  • [ X] Documentation update
  • [ X] Other

Before submitting the PR, please make sure you do the following

  • [√ ] Read the Contributing Guidelines.
  • [ √] Read the Pull Request Guidelines.
  • [√ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [√ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [√ ] Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu requested changes Feb 14, 2023
View reviewed changes
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
packages/core/useElementHover/index.ts Outdated Show resolved Hide resolved
@LockingReal
Copy link
Contributor Author

LockingReal commented Feb 15, 2023 •
edited

@antfu 嘿嘿，老哥，我已经全部改好提交了~，我看npm run test也没有此hook的报错🤭

@LockingReal LockingReal force-pushed the feat-useElementHover-delayprops branch from 1c101fd to 4fc8ad9 Compare February 15, 2023 03:45
@LockingReal LockingReal reopened this Feb 15, 2023
@LockingReal
Copy link
Contributor Author

@antfu 老哥cc~

@LockingReal
Copy link
Contributor Author

@antfu 麻烦老哥再看一下,run test都过啦,我自己也试过啦 🙈

@antfu antfu enabled auto-merge (squash) February 18, 2023 09:14
@antfu antfu changed the title feat(useElementHover): give hook delay properties feat(useElementHover): introduce delay hooks Feb 18, 2023
@antfu antfu merged commit 232834c into vueuse:main Feb 18, 2023
@renovate renovate bot mentioned this pull request Jul 12, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LockingReal @antfu