Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useAxios): added initialData and resetOnExecute options #2791

Merged
merged 4 commits into from Apr 13, 2023
Merged

feat(useAxios): added initialData and resetOnExecute options #2791

merged 4 commits into from Apr 13, 2023

Conversation

Alfred-Skyblue
Copy link
Member

Description

The initialData and resetOnExecute options are added to UseAxiosOptions. We sometimes need to use initialData to ensure that the data structure is correct before the request returns. Use the resetOnExecute option to reset the data to initialData before continuous requests to ensure that the request is obtained when the request is wrong. It is the default value, not the value of the last successful request. If resetOnExecute is set to true, it will be destructive to existing functions, so I temporarily set it to false, but I think its default value should be true. Because this is more expected behavior.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the title feat(useAxios): added initialData and resetOnExecute to options feat(useAxios): added initialData and resetOnExecute options Apr 13, 2023
@antfu antfu enabled auto-merge (squash) April 13, 2023 08:59
@antfu antfu merged commit f54a3c4 into vueuse:main Apr 13, 2023
3 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the feat-useAxios branch April 14, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants