Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFetch): abort before updating state #2805

Merged
merged 1 commit into from Mar 4, 2023
Merged

fix(useFetch): abort before updating state #2805

merged 1 commit into from Mar 4, 2023

Conversation

Alfred-Skyblue
Copy link
Member

Warning: ⚠️ Slowing down new functions

Due to the growing audience of VueUse, we received a huge amount of feature requests and pull requests. It's become harder and harder and recently a bit beyond our capacity to maintain the project. In the near future, we could like slowing down on accepting new features and prioritize the stability and quality of existing functions. New functions to VueUse may not be accpected. If you come up some new ideas, we advice you to have them in your codebase first instead of proposing to VueUse. You may iterate them a few time and see how them suite your needs and how them can be generalized. If you really believe they are useful to the community, you can create PR with your usercases, we are still happy to hear and discuss. Thank you for your understanding.

Description

We should abort the request before loading(false) executes.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the title fix(useFetch): modify the execution order fix(useFetch): abort befure updating state Mar 2, 2023
@antfu antfu added this to the 10.0 milestone Mar 2, 2023
@Alfred-Skyblue Alfred-Skyblue changed the title fix(useFetch): abort befure updating state fix(useFetch): abort before updating state Mar 3, 2023
@antfu antfu merged commit fff4532 into vueuse:main Mar 4, 2023
@Alfred-Skyblue Alfred-Skyblue deleted the fix-useFetch-abort branch March 6, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants