Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTransition): fix regression with non-linear transition functions #2973

Merged
merged 2 commits into from Apr 14, 2023

Conversation

scottbedard
Copy link
Member

@scottbedard scottbedard commented Apr 14, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

There was a regression with useTransition during the change from unreftoValue. Non-linear custom easing functions were returning NaN. This is due to toValue first doing it's own function check, and returning the output of that function rather than the function itself.

This didn't break linear transitions because those are essentially just identity-functions, which return undefined when no input is provided. This led to using the right side of toValue(...) ?? linear, and therefor the default linear transition. With non-linear transitions however, that numeric input is necessary, and without it we end up doing arithmetic on undefined, which leads to the NaN.

I've fixed this with a manual function check, and included a test to cover this situation. Alternatively, we could use the default unref function here to avoid the redundant type checking.

Additional context


🤖 Generated by Copilot at fe1ec45

This pull request adds support for custom easing functions to the useTransition function. It modifies the executeTransition function to handle function parameters and adds a test case to verify the functionality.

🤖 Generated by Copilot at fe1ec45

  • Allow custom easing functions for useTransition (link, link)
  • Add a test case to verify non-linear easing with easeInQuad function (link)

@scottbedard scottbedard requested a review from antfu April 14, 2023 16:34
@antfu antfu changed the title Fix regression with non-linear transition functions fix(useTransition): fix regression with non-linear transition functions Apr 14, 2023
@antfu antfu merged commit 8b3300b into vueuse:main Apr 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants