Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useCycleList): correctly wrap list with ref #2988

Merged
merged 2 commits into from Apr 18, 2023
Merged

fix(useCycleList): correctly wrap list with ref #2988

merged 2 commits into from Apr 18, 2023

Conversation

fan5530
Copy link
Contributor

@fan5530 fan5530 commented Apr 17, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

hello, I found that after updating it to 10.0.2, this function did not work as expected when I passed in an array of object types that were not wrapped in ref

Here's a concrete reproduction: Reproduce

Additional context


🤖 Generated by Copilot at b3f9459

Fixed a bug in useCycleList that prevented the list from updating when the source changed. Used listRef instead of list to access the reactive list of items.

🤖 Generated by Copilot at b3f9459

  • Fixed a bug where the list was not updated when the source changed by using listRef instead of list to access the reactive list of items (link)

@antfu antfu changed the title fix(useCycleList): allow array elements to accept object type fix(useCycleList): correctly wrap list with ref Apr 18, 2023
@antfu antfu merged commit 659b2c9 into vueuse:main Apr 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants