Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMediaControls): apply state when target ref changes #2999

Merged
merged 1 commit into from Apr 19, 2023
Merged

fix(useMediaControls): apply state when target ref changes #2999

merged 1 commit into from Apr 19, 2023

Conversation

ferferga
Copy link
Contributor

@ferferga ferferga commented Apr 19, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

When the target ref element changes, composable state was not being applied to the new DOM element.


馃 Generated by Copilot at 76c6c11

Fix useMediaControls bug with dynamic elements. Update the watch functions for volume, muted, and rate to depend on and use the target element and the composable state values.

馃 Generated by Copilot at 76c6c11

  • Fix bug where composable state was not applied to media element when element or state changed (link)

@ferferga ferferga changed the title fix: apply state when target ref changes fix(useMediaControls): apply state when target ref changes Apr 19, 2023
@antfu antfu merged commit b20aacf into vueuse:main Apr 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants