Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useVModel): clone set to true triggered infinite loop #3097

Merged
merged 2 commits into from Aug 8, 2023

Conversation

motian
Copy link
Contributor

@motian motian commented May 16, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
#3062 ⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

When set clone true, it triggered infinite loop

  1. set property value of proxy.value will trigger watch proxy, and watch triggered emit
  2. for the reason proxy value is a cloned data of props[key!], so watch props[key!] will triggered after step 1's emit
  3. watch props[key!] will set proxy.value a new cloned data, it will triggered watch proxy again (step 1), then infinite loop happened

The problem was not mentioned directly in issue #3062, but mentioned in the issue comment by [Sevody]

 const formData = useVModel(props, 'modelValue', emit, {
    passive: true,
    deep: true,
    clone: true,
 });

Additional context


🤖 Generated by Copilot at 81b4878

Improve useVModel performance and stability by avoiding redundant updates. Use a flag isUpdating to control the proxy value and the emit callback.

🤖 Generated by Copilot at 81b4878

  • Prevent circular updates and unnecessary reactivity overhead for useVModel (link, link)

@stale
Copy link

stale bot commented Jul 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 16, 2023
@antfu antfu removed the stale label Jul 16, 2023
if (!isUpdating) {
isUpdating = true
proxy.value = cloneFn(v) as UnwrapRef<P[K]>
setTimeout(() => isUpdating = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use nextTick here

Copy link
Contributor Author

@motian motian Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using nextTick instead of setTimeout is a better way. Thank you for your advice. I have already tested and changed the commit.

@freddieerg
Copy link

Is there any progress on this? Really should be fixed.

@motian motian force-pushed the motian-patch-1 branch 2 times, most recently from 9d82637 to fab8372 Compare August 1, 2023 02:29
@freddieerg
Copy link

Bumping this, seems like an essential piece of functionality.

@antfu antfu enabled auto-merge August 8, 2023 16:30
@antfu antfu added this pull request to the merge queue Aug 8, 2023
Merged via the queue into vueuse:main with commit 48f4c6e Aug 8, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants