fix(useWebWorker): prevent error event bubbling #3141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ErrorEvent is always bubbled to window, even if we use try-catch to wrap workerFn. I think it's better to prevent the bubble behavior.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
The ErrorEvent is always bubbled to window. If we use 2 or 3 useWebWorkerFn in different vue components, one ErrorEvent from one Fn will cover all these components.
Additional context
🤖 Generated by Copilot at 531edeb
Prevent default error handling of web worker in
useWebWorkerFn
hook. This allows users to catch and handle errors from the worker function without losing the worker instance.🤖 Generated by Copilot at 531edeb