fix(syncRef): avoid infinite sync #3312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixes #3289
fixes #123
).Description
Additional context
🤖 Generated by Copilot at 76294db
This pull request improves the
syncRef
function and its test case. It usespausableWatch
to avoid circular updates when syncing refs with mutual convertors, and it tests more realistic scenarios for the convertor functions. It also refactors thesyncRef
code for readability and consistency.🤖 Generated by Copilot at 76294db
pausableWatch
instead ofwatch
to sync refs with mutual convertors and avoid circular updates (link, link, link, link, link, link)syncRef
with mutual convertors inpackages/shared/syncRef/index.test.ts
to use different initial values and transform functions, and assert the expected values after sync and change (link, link)options
parameter for thesyncRef
function inpackages/shared/syncRef/index.ts
(link)