Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syncRef): avoid infinite sync #3312

Merged
merged 5 commits into from Aug 25, 2023

Conversation

chaii3
Copy link
Contributor

@chaii3 chaii3 commented Aug 13, 2023

#fixes #3289

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context


🤖 Generated by Copilot at 76294db

This pull request improves the syncRef function and its test case. It uses pausableWatch to avoid circular updates when syncing refs with mutual convertors, and it tests more realistic scenarios for the convertor functions. It also refactors the syncRef code for readability and consistency.

🤖 Generated by Copilot at 76294db

  • Use pausableWatch instead of watch to sync refs with mutual convertors and avoid circular updates (link, link, link, link, link, link)
  • Modify the test case for syncRef with mutual convertors in packages/shared/syncRef/index.test.ts to use different initial values and transform functions, and assert the expected values after sync and change (link, link)
  • Add a comment to document the options parameter for the syncRef function in packages/shared/syncRef/index.ts (link)

@chaii3 chaii3 force-pushed the sync_ref_transform_infinite branch from 76294db to 8abee03 Compare August 13, 2023 22:18
if (stop)
return

stop = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the flush paramter of options is 'post', dose it work properly?

@antfu antfu changed the title feat(syncRef): fix infinite sync fix(syncRef): avoid infinite sync Aug 25, 2023
@antfu antfu enabled auto-merge August 25, 2023 16:24
@antfu antfu added this pull request to the merge queue Aug 25, 2023
Merged via the queue into vueuse:main with commit bc9665d Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syncRef custom Maximum call stack size exceeded
3 participants