fix(utils): update isClient
to check document
too
#3329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
isClient
implementation checks whetherwindow
is defined or not. This breaks things when using SSR with Deno aswindow
is defined there (https://deno.land/api@v1.36.1?s=Window)Additional context
馃 Generated by Copilot at 0c222fe
Fixed a bug in
isClient
function that incorrectly detected browser environments. Changed the function to usedocument
instead ofwindow
inpackages/shared/utils/is.ts
.馃 Generated by Copilot at 0c222fe
isClient
returns true in non-browser environments (link)