Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useAsyncQueue): support in infinite tasks in typescript #3333

Merged

Conversation

ethansnow2012
Copy link
Contributor

@ethansnow2012 ethansnow2012 commented Aug 21, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

I found useAsyncQueue can only take up to 5 task in typescript(T1, T2, T3, T4, T5 in code).
Is it better for us to accept an infinite number of tasks?

like this

// const p1OfString: () => Promise<string>
// const p2OfNumber: (result: number) => Promise<number>

const {
      activeIndex,
      result,
    } = useAsyncQueue<[string, number, string, number, string, number, string, number]>([p1OfString, p2OfNumber, p1OfString, p2OfNumber, p1OfString, p2OfNumber, p1OfString, p2OfNumber])

// result: [UseAsyncQueueResult<string>, 
//   UseAsyncQueueResult<number>, 
//    UseAsyncQueueResult<string>, 
//    UseAsyncQueueResult<number>, 
//    UseAsyncQueueResult<...>, 
//    UseAsyncQueueResult<...>, 
//    UseAsyncQueueResult<...>, 
//    UseAsyncQueueResult<...>
// ]

Additional context


🤖 Generated by Copilot at b5304b4

This pull request enhances the useAsyncQueue function to handle errors better and to be more type-safe and concise. It introduces a new AsyncQueueTask type and refactors the function parameters and return value.

🤖 Generated by Copilot at b5304b4

  • Introduce MapQueueTask type alias to map tasks to results (link)
  • Simplify useAsyncQueue signatures and return type using MapQueueTask and conditional type (link, link)
  • Add fallback value for options parameter in useAsyncQueue to prevent destructuring error (link)

@antfu antfu enabled auto-merge August 25, 2023 11:24
@antfu antfu added this pull request to the merge queue Aug 25, 2023
Merged via the queue into vueuse:main with commit 22e26dc Aug 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants