Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useClipboard): use legacy way when without permission #3379

Merged
merged 7 commits into from Nov 9, 2023

Conversation

Cat1007
Copy link
Contributor

@Cat1007 Cat1007 commented Sep 7, 2023

fixes #2494

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

use legacy methods as a fallback when clipboard is supported but without permission

Additional context


🤖 Generated by Copilot at f04e403

This pull request enhances the useClipboard function with permission checks. It uses the usePermission function to query and request the clipboard permission before reading or writing to the clipboard.

🤖 Generated by Copilot at f04e403

  • Import usePermission function to check clipboard access (link)
  • Declare permissionRead and permissionWrite variables to store the result of usePermission (link)
  • Modify updateText function to conditionally call navigator.clipboard.readText based on permissionRead (link)
  • Modify copy function to conditionally call navigator.clipboard.writeText based on permissionWrite (link)

@Cat1007 Cat1007 marked this pull request as draft October 26, 2023 06:16
@Cat1007 Cat1007 marked this pull request as ready for review October 26, 2023 06:18
@Cat1007
Copy link
Contributor Author

Cat1007 commented Oct 26, 2023

@antfu could you please approve the check

Copy link
Contributor

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably test it goes for the legacy method when the permission is denied

packages/core/useClipboard/index.ts Outdated Show resolved Hide resolved
packages/core/useClipboard/index.ts Outdated Show resolved Hide resolved
Cat1007 and others added 2 commits October 26, 2023 17:26
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
@Cat1007
Copy link
Contributor Author

Cat1007 commented Oct 26, 2023

You should probably test it goes for the legacy method when the permission is denied

My mistake, thanks for your correction

@antfu antfu changed the title fix(useClipboard): 🐛 use legacy way when without permission fix(useClipboard): use legacy way when without permission Nov 9, 2023
@antfu antfu enabled auto-merge November 9, 2023 16:38
@antfu antfu added this pull request to the merge queue Nov 9, 2023
Merged via the queue into vueuse:main with commit 37e866c Nov 9, 2023
4 checks passed
@Mister-Hope
Copy link
Contributor

This pr has a few bugs and I will open a new pr #3812 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useClipboard doesn't fallback to legacy in iframe
4 participants