Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useMousePressed): add capture option #3392

Merged
merged 3 commits into from Oct 7, 2023

Conversation

DerZade
Copy link
Contributor

@DerZade DerZade commented Sep 12, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

This PR adds a new capture option to the useMousePressed function.

Additional context

None


🤖 Generated by Copilot at 8963d90

Added a new option to useMousePressed to customize event propagation. Updated the code and docs in packages/core/useMousePressed/index.ts.

🤖 Generated by Copilot at 8963d90

  • Add capture option to useMousePressed hook to control event propagation order (link, link, link)
  • Update MousePressedOptions interface with capture option and JSDoc comment (link)
  • Destructure capture option from options parameter in useMousePressed function (link)
  • Pass capture option to useEventListener calls for mouse and touch events in useMousePressed function (link)

@antfu antfu enabled auto-merge October 7, 2023 07:13
antfu
antfu previously approved these changes Oct 7, 2023
@antfu antfu disabled auto-merge October 7, 2023 08:47
@antfu antfu merged commit d5c81b3 into vueuse:main Oct 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants