fix(useWebSocket): webworker support #3469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
This PR solves the issue when useWebsocket is used in a webworker.
Additional context
The bug was introduced with PR fix(useWebSocket): ssr support
#3370
🤖 Generated by Copilot at e648dd4
Added
isWorker
utility function to check for web worker environment and used it to improveuseWebSocket
compatibility with web workers.🤖 Generated by Copilot at e648dd4
isWorker
function to@vueuse/shared/utils/is.ts
to check if the current environment is a web worker (link)isWorker
function inuseWebSocket
and use it to return early fromopen
function if the environment is a web worker, since web workers cannot use thewindow.WebSocket
constructor (link, link)