Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useDateFormat): add date ordinal formatting #3474

Merged
merged 3 commits into from Nov 9, 2023

Conversation

loongzhu
Copy link
Contributor

@loongzhu loongzhu commented Oct 13, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

feat(useDateFormat): Add Date ordinal formatting to useDateFormat() #3472


🤖 Generated by Copilot at e0830b1

This pull request adds ordinal formatting for date and time tokens in useDateFormat. It allows users to display the year, month, day, hour, minute, and second with ordinal suffixes in their formatted strings. It also updates the documentation and examples of the function in index.md.

🤖 Generated by Copilot at e0830b1

  • Add ordinal formatting feature for date and time values (link, link, link)
  • Modify the regular expression to match the new tokens with o suffix (link)
  • Define and add the functions to replace the tokens with values and ordinal suffixes in formatDate (link)
  • Update the documentation with examples and descriptions of the new tokens in useDateFormat/index.md (link)

antfu
antfu previously approved these changes Nov 9, 2023
@antfu antfu changed the title feat(useDateFormat): Add Date ordinal formatting to useDateFormat() feat(useDateFormat): add date ordinal formatting Nov 9, 2023
@antfu antfu added this pull request to the merge queue Nov 9, 2023
Merged via the queue into vueuse:main with commit 61ceb19 Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants