Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFetch): don't set isFetching to false when a request is aborted because of a refetch #3479

Merged
merged 4 commits into from Nov 9, 2023

Conversation

mweghorst
Copy link
Contributor

@mweghorst mweghorst commented Oct 16, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Fixes #3300

Whenever a request is canceled because of a refetch, isFetching becomes incorrect because the aborted request sets it to false in the finally block.

Additional context

I copied the solution from useAxios:

executeCounter += 1
const currentExecuteCounter = executeCounter
instance(_url, { ...defaultConfig, ...typeof executeUrl === 'object' ? executeUrl : config, cancelToken: cancelToken.token })
.then((r: any) => {
response.value = r
const result = r.data
data.value = result
onSuccess(result)
})
.catch((e: any) => {
error.value = e
onError(e)
})
.finally(() => {
options.onFinish?.()
if (currentExecuteCounter === executeCounter)
loading(false)
})


🤖 Generated by Copilot at 5d7c249

Fixed a bug in useFetch that caused isFetching to be inaccurate when multiple requests are made. Added a counter to track the latest request and ignore the previous ones.

🤖 Generated by Copilot at 5d7c249

  • Add executeCounter variable to useFetch function to track the number of fetch requests (link, link)
  • Prevent loading function from setting isFetching state to false when previous fetch requests are finished, by comparing currentExecuteCounter with executeCounter (link)

@fprl
Copy link

fprl commented Oct 30, 2023

Having the same problem! Will this be merged? Thanks

antfu
antfu previously approved these changes Nov 9, 2023
@antfu antfu enabled auto-merge November 9, 2023 16:39
@antfu antfu added this pull request to the merge queue Nov 9, 2023
Merged via the queue into vueuse:main with commit 75ca2bb Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useFetch: isFetching is false if previous request was cancelled
3 participants