Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onClickOutside): adjust shouldListen handling timing #3503

Merged
merged 2 commits into from Nov 9, 2023

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented Oct 25, 2023

even if the target is falsy, we should care about the ignore options

fix #3465

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

In current logic, if the target is falsy when the event trigger, it won't care about the ignore options which make no sense.
This PR change the logic to judge if should ignore at first before any other judgements related with e

Additional context


🤖 Generated by Copilot at 018e21c

Refactor and optimize the onClickOutside function in packages/core/onClickOutside/index.ts by simplifying and reordering the logic for setting the shouldListen variable.

🤖 Generated by Copilot at 018e21c

  • Simplify and optimize the logic for setting shouldListen (link)

even if the target is falsy, we should care about the ignore options

fix vueuse#3465
@Doctor-wu
Copy link
Member Author

@antfu This is a replacement PR for #3470

@Doctor-wu
Copy link
Member Author

@antfu This is a replacement PR for #3470

I simply changed a branch to send a PR since I need to contribute some new codes based on the origin branch

@antfu antfu enabled auto-merge November 9, 2023 14:58
@antfu antfu added this pull request to the merge queue Nov 9, 2023
@Doctor-wu
Copy link
Member Author

Thanks for merge~

Merged via the queue into vueuse:main with commit 6985152 Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnClickoutside: the callback was triggered accidentally when the target is undefined
2 participants