Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useFileDialog): add directory parameters #3513

Merged

Conversation

huiliangShen
Copy link
Contributor

@huiliangShen huiliangShen commented Oct 30, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context


🤖 Generated by Copilot at 262a1aa

This pull request adds a new feature to the useFileDialog hook that enables directory selection in some browsers. It also updates the documentation with an example of using this feature.

🤖 Generated by Copilot at 262a1aa

  • Add directory option to useFileDialog hook to enable selecting directories in the file dialog (link, link, link, link)
  • Update the UseFileDialogOptions interface and the DEFAULT_OPTIONS constant to include the directory option, which is a boolean that defaults to false (link, link)
  • Set the webkitdirectory attribute of the input element to the value of the directory option, using a non-standard feature that works in some browsers (link)
  • Add an example of using the directory option in the documentation file index.md (link)

@Alfred-Skyblue Alfred-Skyblue linked an issue Oct 31, 2023 that may be closed by this pull request
4 tasks
Copy link

@JakobMiksch JakobMiksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and it works well!
Would be great to merge this soon :-)

@antfu antfu added this pull request to the merge queue Nov 9, 2023
Merged via the queue into vueuse:main with commit cefca9a Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useFileDialog: enable uploading a directory instead of files
4 participants