Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useDraggable): element can't relative parent element move #3531

Conversation

huiliangShen
Copy link
Contributor

@huiliangShen huiliangShen commented Nov 4, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

change code

// original code
// when container not null, we need add rect.left and reduce targetRect.left
// because move function will reduce pos.x, it's will calc error x
// then get the change pos.x = e.clientX - targetRect.left + containerRect.left
const container = toValue(containerElement) ?? toValue(target)
const rect = container!.getBoundingClientRect()
const pos = {
  x: e.clientX - rect.left,
  y: e.clientY - rect.top,
}

is there anything you'd like reviewers to focus on?

  • attention should be paid to more unexpected scenes
  • check the change of set child elements to be drag within the parent element range

🤖 Generated by Copilot at 5a0ea31

Fix position bug and add null checks for container option in useDraggable hook. This improves the functionality and reliability of the hook when using a custom container element.

🤖 Generated by Copilot at 5a0ea31

  • Add a new feature to the useDraggable hook that allows specifying a container element that limits the draggable area (

@antfu antfu merged commit 082462d into vueuse:main Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants