Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useStorage): fix defaults not unwrapped #3534

Merged
merged 3 commits into from Nov 9, 2023
Merged

fix(useStorage): fix defaults not unwrapped #3534

merged 3 commits into from Nov 9, 2023

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Nov 8, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

fixed #3417

⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context


🤖 Generated by Copilot at 56e032e

Refactor useStorage function to simplify initial value handling and serialization. Update packages/core/useStorage/index.ts accordingly.

🤖 Generated by Copilot at 56e032e

  • Introduce defaultValue variable to store the result of applying toValue to the defaults option in useStorage (link)
  • Use defaultValue instead of defaults to determine the storage serializer type and the initial value of the data ref in useStorage (link)

@antfu antfu enabled auto-merge November 9, 2023 14:35
@antfu antfu added this pull request to the merge queue Nov 9, 2023
Merged via the queue into vueuse:main with commit b6d2bd3 Nov 9, 2023
4 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the fix/useStorage/defaults branch November 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useStore not unwrapping MaybeRefOrGetter
2 participants