fix(useActiveElement/useFocusWithin): replace computedWithControl with locally tracked ref #3815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
useActiveElement and useFocusWithin are currently broken due to computedWithControl being used inside of computed triggering the following warning:
This PR replaces computedWithControl with a locally tracked ref so useActiveElement can be used inside a computed as done in useFocusWithin:
vueuse/packages/core/useFocusWithin/index.ts
Lines 23 to 25 in 1b67d96
Additional context
related issues: #3799, #3794, #3787, #3774, #3760
upstream issue: vuejs/core#10341