From f5a825e34cc46055e073961cc3830c7ca4e3b8a4 Mon Sep 17 00:00:00 2001
From: Nikita Mikhailov <mikhaylovnv.dev@gmail.com>
Date: Wed, 3 Aug 2022 19:44:40 +0300
Subject: [PATCH 1/2] fix(useFavicon): writable return type

---
 packages/core/useFavicon/index.ts | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/packages/core/useFavicon/index.ts b/packages/core/useFavicon/index.ts
index e4aa4f53529..6e9993ef1cc 100644
--- a/packages/core/useFavicon/index.ts
+++ b/packages/core/useFavicon/index.ts
@@ -1,5 +1,6 @@
-import type { MaybeComputedRef } from '@vueuse/shared'
+import type { MaybeRef } from '@vueuse/shared'
 import { isString, resolveRef } from '@vueuse/shared'
+import type { ComputedRef, Ref, WritableComputedRef } from 'vue-demi'
 import { watch } from 'vue-demi'
 import type { ConfigurableDocument } from '../_configurable'
 import { defaultDocument } from '../_configurable'
@@ -9,6 +10,9 @@ export interface UseFaviconOptions extends ConfigurableDocument {
   rel?: string
 }
 
+export type UseFaviconValue = string | null | undefined
+export type UseFaviconGetter = () => UseFaviconValue
+
 /**
  * Reactive favicon.
  *
@@ -16,8 +20,11 @@ export interface UseFaviconOptions extends ConfigurableDocument {
  * @param newIcon
  * @param options
  */
+export function useFavicon(newIcon: ComputedRef<UseFaviconValue> | UseFaviconGetter, options?: UseFaviconOptions): ComputedRef<UseFaviconValue>
+export function useFavicon(newIcon: MaybeRef<UseFaviconValue>, options?: UseFaviconOptions): Ref<UseFaviconValue>
+export function useFavicon(newIcon?: ComputedRef<UseFaviconValue> | MaybeRef<UseFaviconValue> | UseFaviconGetter, options?: UseFaviconOptions): Ref<UseFaviconValue>
 export function useFavicon(
-  newIcon: MaybeComputedRef<string | null | undefined> = null,
+  newIcon: ComputedRef<UseFaviconValue> | MaybeRef<UseFaviconValue> | UseFaviconGetter = null,
   options: UseFaviconOptions = {},
 ) {
   const {
@@ -43,7 +50,6 @@ export function useFavicon(
     { immediate: true },
   )
 
-  return favicon
+  return favicon as WritableComputedRef<string | null | undefined>
 }
-
 export type UseFaviconReturn = ReturnType<typeof useFavicon>

From 8a95d1c40f0037ebf2263a8dbe071c13680a1633 Mon Sep 17 00:00:00 2001
From: Anthony Fu <anthonyfu117@hotmail.com>
Date: Thu, 4 Aug 2022 11:58:51 +0800
Subject: [PATCH 2/2] chore: update

---
 packages/core/useFavicon/index.ts | 19 +++++++++++--------
 packages/shared/utils/types.ts    | 13 +++++++++++--
 2 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/packages/core/useFavicon/index.ts b/packages/core/useFavicon/index.ts
index 6e9993ef1cc..42b8b77ee4a 100644
--- a/packages/core/useFavicon/index.ts
+++ b/packages/core/useFavicon/index.ts
@@ -1,4 +1,4 @@
-import type { MaybeRef } from '@vueuse/shared'
+import type { MaybeComputedRef, MaybeReadonlyRef, MaybeRef } from '@vueuse/shared'
 import { isString, resolveRef } from '@vueuse/shared'
 import type { ComputedRef, Ref, WritableComputedRef } from 'vue-demi'
 import { watch } from 'vue-demi'
@@ -10,9 +10,6 @@ export interface UseFaviconOptions extends ConfigurableDocument {
   rel?: string
 }
 
-export type UseFaviconValue = string | null | undefined
-export type UseFaviconGetter = () => UseFaviconValue
-
 /**
  * Reactive favicon.
  *
@@ -20,11 +17,16 @@ export type UseFaviconGetter = () => UseFaviconValue
  * @param newIcon
  * @param options
  */
-export function useFavicon(newIcon: ComputedRef<UseFaviconValue> | UseFaviconGetter, options?: UseFaviconOptions): ComputedRef<UseFaviconValue>
-export function useFavicon(newIcon: MaybeRef<UseFaviconValue>, options?: UseFaviconOptions): Ref<UseFaviconValue>
-export function useFavicon(newIcon?: ComputedRef<UseFaviconValue> | MaybeRef<UseFaviconValue> | UseFaviconGetter, options?: UseFaviconOptions): Ref<UseFaviconValue>
 export function useFavicon(
-  newIcon: ComputedRef<UseFaviconValue> | MaybeRef<UseFaviconValue> | UseFaviconGetter = null,
+  newIcon?: MaybeReadonlyRef<string | null | undefined>,
+  options?: UseFaviconOptions
+): ComputedRef<string | null | undefined>
+export function useFavicon(
+  newIcon: MaybeRef<string | null | undefined>,
+  options?: UseFaviconOptions
+): Ref<string | null | undefined>
+export function useFavicon(
+  newIcon: MaybeComputedRef<string | null | undefined> = null,
   options: UseFaviconOptions = {},
 ) {
   const {
@@ -52,4 +54,5 @@ export function useFavicon(
 
   return favicon as WritableComputedRef<string | null | undefined>
 }
+
 export type UseFaviconReturn = ReturnType<typeof useFavicon>
diff --git a/packages/shared/utils/types.ts b/packages/shared/utils/types.ts
index d0189383931..ddac273e445 100644
--- a/packages/shared/utils/types.ts
+++ b/packages/shared/utils/types.ts
@@ -31,10 +31,19 @@ export type MaybeRef<T> = T | Ref<T>
  * Maybe it's a ref, or a plain value, or a getter function
  *
  * ```ts
- * type MaybeComputedRef<T> = T | Ref<T> | (() => T)
+ * type MaybeComputedRef<T> = (() => T) | T | Ref<T> | ComputedRef<T>
  * ```
  */
-export type MaybeComputedRef<T> = (() => T) | T | Ref<T> | ComputedRef<T>
+export type MaybeComputedRef<T> = MaybeReadonlyRef<T> | MaybeRef<T>
+
+/**
+ * Maybe it's a computed ref, or a getter function
+ *
+ * ```ts
+ * type MaybeReadonlyRef<T> = (() => T) | ComputedRef<T>
+ * ```
+ */
+export type MaybeReadonlyRef<T> = (() => T) | ComputedRef<T>
 
 /**
  * Make all the nested attributes of an object or array to MaybeRef<T>