You shouldn't be able to run package info commands not in js/ts project

[vuki656]

If you run change_version in a lua project, it still opens the dialog.

Detection can probably be done by trying to find a package.json

[danielo515]

What about only attaching the key maps when the uffer name is exactly package.json ? I think most if not all, commands does not make sense outside of it anyway

[vuki656]

What about only attaching the key maps when the uffer name is exactly package.json ? I think most if not all, commands does not make sense outside of it anyway

True for some but not for all. For example sometimes when I'm working on a ts project in some random file, I run PackageInfoInstall to add a package and don't have to go to the terminal or package JSON to do it.

[danielo515]

But that is you actively running the command, which should always be possible, but the keymaps should not El vie., 17 jun. 2022 14:57, Domagoj ***@***.***> escribió:

…

What about only attaching the key maps when the uffer name is exactly package.json ? I think most if not all, commands does not make sense outside of it anyway True for some but not for all. For example sometimes when I'm working on a ts project in some random file, I run PackageInfoInstall to add a package and don't have to go to the terminal or package JSON to do it. — Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARKJWNTZE3FXT7ZRKNOIQ3VPRYZXANCNFSM5LCO4IPQ> . You are receiving this because you commented.Message ID: ***@***.***>