Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Update Readme keymap config examples with description #137

Open
1 task done
dzintars opened this issue Dec 10, 2022 · 1 comment
Open
1 task done
Labels
🙏 Feature Request Feature requests not planned anywhere

Comments

@dzintars
Copy link

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

I would suggest to update key binding examples to:

vim.api.nvim_set_keymap(
    "n",
    "<leader>ns",
    "<cmd>lua require('package-info').show()<cr>",
    { silent = true, noremap = true, desc = "package-info | Show" }
)

Note the , desc = "package-info | Show" addition.

While this is "opinionated" thing to do, I do believe that newer Nvim users will benefit of cleaner :map n or :Telescope keymaps or which-key key descriptions. This enables easier duplicate keybinding finding and seeing "what is what and from where does it comes".

Also, examples could be improved with vim.keymap.set()

Help

Yes

Implementation help

No response

@dzintars dzintars added the 🙏 Feature Request Feature requests not planned anywhere label Dec 10, 2022
@vuki656
Copy link
Owner

vuki656 commented Dec 20, 2022

Makes sense. Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Feature Request Feature requests not planned anywhere
Projects
None yet
Development

No branches or pull requests

2 participants