Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: Retiring formula in Homebrew #15

Open
javian opened this issue Mar 30, 2018 · 10 comments
Open

FYI: Retiring formula in Homebrew #15

javian opened this issue Mar 30, 2018 · 10 comments

Comments

@javian
Copy link

javian commented Mar 30, 2018

Since the php tap is being merged into homebrew-core we are reviewing the most popular formulas. We are not able to migrate the formula for this repo over since it needs to be adapted to how php is set up and that there no longer is an xdebug formula once the old tap is retired.

@w00fz
Copy link
Owner

w00fz commented Mar 30, 2018

Very sad but thank you for letting me know!

@gpressutto5
Copy link

Any news?

@javian
Copy link
Author

javian commented Apr 4, 2018

@w00fz will probably accept PRs if anyone is willing to get their hands dirty =)

@endelwar
Copy link
Contributor

@javian I've just pushed a PR for this, do you mind testing it? #16

@w00fz
Copy link
Owner

w00fz commented Apr 19, 2018

Is there anyway we can not hardcode the 7.2 version and pull that information from brew?

@endelwar
Copy link
Contributor

I think that the hardcoded php version is resolved with last push.
@javian any change to reconsider xdebug-osx inclusion in homebrew-core once #16 get merged and a new release is done?

@w00fz
Copy link
Owner

w00fz commented Apr 19, 2018

Thank you @endelwar !

@javian
Copy link
Author

javian commented Apr 23, 2018

@endelwar its a matter of someone writing a formula for it which should be pretty simple and then creating test block for it which usually is the trickier part depending on the software.

@webflo
Copy link
Contributor

webflo commented Jan 17, 2019

Related PR: #18

@webflo
Copy link
Contributor

webflo commented Jan 26, 2019

Fixed in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants